feat(firebase-ai): add inlineData support to Developer API #17600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Developer API was missing support for parts, which was already implemented in the Vertex AI API. This change copies the parsing logic from the Vertex AI function to the function in the Developer API. An existing test file, , has been updated to include a test case for parsing parts, ensuring the functionality is working as expected.
ryanwilson
changed the title
Lyokone
approved these changes
Aug 6, 2025
SelaseKay
approved these changes
Aug 6, 2025
russellwheatley
approved these changes
Aug 6, 2025
gspencergoog
pushed a commit
to gspencergoog/flutterfire
that referenced
this pull request
Aug 14, 2025
The Developer API was missing support for parts, which was already implemented in the Vertex AI API. This change copies the parsing logic from the Vertex AI function to the function in the Developer API. An existing test file, , has been updated to include a test case for parsing parts, ensuring the functionality is working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Developer API was missing support for
inlineDataparts, which was already implemented in the Vertex AI API.This change copies the
inlineDataparsing logic from the Vertex AIparsePartfunction to the_parsePartfunction in the Developer API.The existing test file,
developer_api_test.dart, has been updated to include a test case for parsinginlineDataparts, ensuring the functionality is working as expected.Tested in the iOS simulator with a manual change to the sample (not included, since it likely warrants further example changes)
Related Issues
Fixes #17449
There was a previous attempt at this but it was closed: #17451
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?