Skip to content

chore(firebaseai): remove generateContent call from count tokens page #17613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

ryanwilson
Copy link
Member

Description

This isn't clear in the sample UI why this is happening, and ends up using more tokens than necessary.

Related Issues

Internal bug report.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

This isn't clear in the sample UI why this is happening, and ends up using more tokens than necessary.
@SelaseKay SelaseKay changed the title Remove generateContent call from count tokens page chore: remove generateContent call from count tokens page Aug 12, 2025
@ryanwilson ryanwilson requested a review from cynthiajoan August 13, 2025 12:35
@cynthiajoan cynthiajoan changed the title chore: remove generateContent call from count tokens page chore(firebaseai): remove generateContent call from count tokens page Aug 13, 2025
@SelaseKay SelaseKay merged commit db913d8 into main Aug 14, 2025
15 of 16 checks passed
@SelaseKay SelaseKay deleted the fix/sample-token-count branch August 14, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants