-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[image_picker] redesign example app #9625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
JFYI you need to update the change log. There is a failing test complaining about that. |
The iOS example now uses FloatingActionButton.extended
@rekire Thank you for looking into the failing test. I've updated the changelog but was not sure wether a version bump is necessary. Could you please confirm? |
test-exempt: this is a Flutter-team-facing test app, so doesn't need testing of UI |
CHANGELOG/version override: Although this file is published to pub.dev, the change here isn't relevant to package clients, only to local package developers, so it doesn't matter if/when it is published. |
Replaces FloatingActionButton with FloatingActionButton.extended in Linux, macOS, and Windows example apps for improved button labeling.
Replace default
FloatingActionButton
s withFloatingActionButton.extended
to add text labels describing each button's actionfixes flutter/flutter#165888
|
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3