Skip to content

[image_picker] redesign example app #9625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

syedaniq
Copy link

Replace default FloatingActionButtons with FloatingActionButton.extended to add text labels describing each button's action

fixes flutter/flutter#165888

before after
image image

|

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@rekire
Copy link

rekire commented Jul 15, 2025

JFYI you need to update the change log. There is a failing test complaining about that.

syedaniq added 2 commits July 15, 2025 09:23
The iOS example now uses FloatingActionButton.extended
@syedaniq
Copy link
Author

@rekire Thank you for looking into the failing test. I've updated the changelog but was not sure wether a version bump is necessary. Could you please confirm?

@stuartmorgan-g
Copy link
Contributor

test-exempt: this is a Flutter-team-facing test app, so doesn't need testing of UI

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jul 15, 2025
@stuartmorgan-g
Copy link
Contributor

CHANGELOG/version override: Although this file is published to pub.dev, the change here isn't relevant to package clients, only to local package developers, so it doesn't matter if/when it is published.

syedaniq added 2 commits July 15, 2025 23:57
Replaces FloatingActionButton with FloatingActionButton.extended in Linux, macOS, and Windows example apps for improved button labeling.
@syedaniq syedaniq requested a review from cbracken as a code owner July 15, 2025 23:09
@syedaniq syedaniq changed the title [image_picker][ios] redesign example app [image_picker] redesign example app Jul 15, 2025
@syedaniq syedaniq requested a review from stuartmorgan-g July 15, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: image_picker platform-android platform-ios platform-linux platform-macos platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[image_picker] [ios] example app could benefit from redesign
3 participants