chore: Add unused deps lint #10666
Merged
chore: Add unused deps lint #10666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenethan01
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
DaniPopes
reviewed
May 30, 2025
crates/forge/bin/main.rs
Outdated
| @@ -1,6 +1,8 @@ | |||
| //! The `forge` CLI: build, test, fuzz, debug and deploy Solidity contracts, like Hardhat, Brownie, | |||
| //! Ape. | |||
|
|
|||
| #![cfg_attr(not(test), warn(unused_crate_dependencies))] | |||
There was a problem hiding this comment.
sorry i should've specified to do it only in lib.rs, as main.rs will have unnecessary warnings
There was a problem hiding this comment.
No worries, re-added to main files. Still seeing the false positives where removing the warned dependencies throws errors as the dependencies are used in test files and the linter specifies not(test). In this case should I add use toml as _; etc. in the crate root to silence the warnings as make pr is currenly failing due to the linting?
There was a problem hiding this comment.
in that case you need to move them to dev-dependencies
There was a problem hiding this comment.
addressed, thanks!
zerosnacks
approved these changes
Jun 2, 2025
DaniPopes
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes issue #10665
Solution
Add
#![cfg_attr(not(test), warn(unused_crate_dependencies))]to ALL cratesPR Checklist
Add
unused_crate_dependencieslint to all cratesThis adds
#![cfg_attr(not(test), warn(unused_crate_dependencies))]to alllibrary and binary crates as requested in #10665.