refactor(verify): remove redundant logging in Etherscan provider #11048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crStiv
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
requested changes
Jul 24, 2025
tnx for the review, does it make sense now? |
kaxhnet
approved these changes
Jul 26, 2025
kaxhnet
approved these changes
Jul 26, 2025
mattsse
requested changes
Jul 27, 2025
| @@ -109,14 +108,11 @@ impl VerificationProvider for EtherscanVerificationProvider { | |||
| if resp.result.starts_with("Unable to locate ContractCode at") | |||
| || resp.result.starts_with("The address is not a smart contract") | |||
| { | |||
| warn!("{}", resp.result); | |||
There was a problem hiding this comment.
actually we should log this because this usually provides useful context for debugging
| } | ||
|
|
||
| warn!("Failed verify submission: {:?}", resp); |
| @@ -186,7 +182,7 @@ impl VerificationProvider for EtherscanVerificationProvider { | |||
| } | |||
|
|
|||
| if resp.status == "0" { | |||
| return Err(RetryError::Break(eyre!("Contract failed to verify."))); | |||
| return Err(RetryError::Break(eyre!("Contract verification failed - status: {}, result: {}", resp.status, resp.result))); | |||
There was a problem hiding this comment.
maybe adding this to the actual error is better @grandizzy
There was a problem hiding this comment.
makes sense, anything that helps figuring out why verification failed is good to have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant warn!/error! calls to reduce log noise and improve clarity