Skip to content

feat(anvil): added js tracer #11052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 25, 2025
Merged

Conversation

Soubhik-10
Copy link
Contributor

@Soubhik-10 Soubhik-10 commented Jul 20, 2025

this has a patched dep.. now the deps match :)
closes #10977
Closes #6764

@Soubhik-10 Soubhik-10 changed the title added js tracer feat: added js tracer Jul 20, 2025
@grandizzy grandizzy changed the title feat: added js tracer feat(anvil): added js tracer Jul 20, 2025
@Soubhik-10 Soubhik-10 marked this pull request as ready for review July 24, 2025 12:17
mattsse
mattsse previously approved these changes Jul 24, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@DaniPopes this introduces boa into the anvil dep graph, should we also feature gate this or is this fine?

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you, left one nit.
Also this adds bunch of new deps, which I think it's fine @DaniPopes could you pls chime in?

@DaniPopes
Copy link
Member

Let's feature gate like we do for aws: disabled by default but enabled in makefile/release ci

@mattsse
Copy link
Member

mattsse commented Jul 25, 2025

@Soubhik-10 then this would look similar to:

https://github.com/paradigmxyz/reth/blob/a7cbf81b65acacbca5e089593d0516ade936550f/crates/rpc/rpc/src/debug.rs#L413-L418

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we also need to activate this for release builds here:

source $HOME/.profile && cargo build --release --features cast/aws-kms,cast/gcp-kms,forge/aws-kms,forge/gcp-kms \

like anvil/js-tracer

@Soubhik-10 Soubhik-10 requested review from mattsse and grandizzy July 25, 2025 14:02
mattsse
mattsse previously approved these changes Jul 25, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse
Copy link
Member

mattsse commented Jul 25, 2025

@grandizzy do we also need to add this feature here:

foundry/Makefile

Lines 49 to 55 in 391f37f

FEATURES="jemalloc aws-kms gcp-kms cli asm-keccak" $(MAKE) build-x86_64-unknown-linux-gnu
mkdir -p $(BIN_DIR)/amd64
for bin in anvil cast chisel forge; do \
cp $(CARGO_TARGET_DIR)/x86_64-unknown-linux-gnu/$(PROFILE)/$$bin $(BIN_DIR)/amd64/; \
done
FEATURES="aws-kms gcp-kms cli asm-keccak" $(MAKE) build-aarch64-unknown-linux-gnu

@grandizzy
Copy link
Collaborator

@grandizzy do we also need to add this feature here:

foundry/Makefile

Lines 49 to 55 in 391f37f

FEATURES="jemalloc aws-kms gcp-kms cli asm-keccak" $(MAKE) build-x86_64-unknown-linux-gnu
mkdir -p $(BIN_DIR)/amd64
for bin in anvil cast chisel forge; do \
cp $(CARGO_TARGET_DIR)/x86_64-unknown-linux-gnu/$(PROFILE)/$$bin $(BIN_DIR)/amd64/; \
done
FEATURES="aws-kms gcp-kms cli asm-keccak" $(MAKE) build-aarch64-unknown-linux-gnu

yeah, unfortunately features are now specified in multiple places, needs to be updated here for non docker build as well https://github.com/foundry-rs/foundry/blob/master/.github/workflows/release.yml#L162

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse merged commit b57f7c1 into foundry-rs:master Jul 25, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(anvil): Anvil returns "unsupported tracer type" error feat(anvil): add support for JS tracer in Anvil
5 participants