Remove the --froms flag #11099
Merged
Remove the --froms flag #11099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
requested review from
DaniPopes,
klkvr,
mattsse and
grandizzy
as code owners
|
Hi @CodeSandwich thanks for your PR 👍 ! Can we mark this PR as effectively resolving #10845 and make #10840 redundant? |
|
Yeah, I think so, my great spat with |
zerosnacks
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
--fromsflag is dead. This is the continuation of this thread: #10929 (comment).Closes: #10840
Closes: #10845
Solution
Remove the
--fromsflag. I haven't marked it as a breaking change because there was no valid use case for it.PR Checklist