Integrate dotnet/fsharp from 4f5f08320 to 7b25d7f82 #918

baronfel · 2019-12-09T18:07:57Z

Notable changes include:

Addition of the FsharpUnionCase.HasFields property
FCS builds entirely on .Net Core now
Better debug information for ranges
Support for Literal values in signature files
Using memory-mapped files cross-platform to read IL.

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

* update build definition to use stages * disable arcade NuGet package validation

…370) Due to internal package publishing policies, the author of a package published via a Microsoft account must be exactly 'Microsoft'. To preserve attribution to the F# Software Foundation, mention is made in the <description> tag of FSharp.Core.

[release/dev16.4] cherry-pick yaml updates to 16.4

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

… (#7499) * turn off broken source link validation * add VS insertion logic to build pipeline

This fixes an issue where VS Setup was NGENing all of the FSharp.*.resources.dll assemblies.

* Eliminate Relax requirement to apply --noframework when referencing mscorlib/system.runtime.dll/netstandard.dll * Relax requirement to pass --noframework with System.Runtime, netstandard and mscorlib.dll

Merge master to release/dev16.4

…923.5 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19473.5

* Add a bind to Parallel test to force async continuations * Fixing Parallel and more tests * Use trampoline holder directly * Split race test to check with and without max degree * Fix RaceBetweenCancellationAndError tests (use an async that errors)

…926.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19476.6

Merge master to release/dev16.4

…-a189-a6dc389f609c' into package-icon

replace deprecated nuspec `iconUrl` element with `icon`

Only the 16.3 build uses this file and that branch still has a copy.

…119.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19569.6

* Minor pickle optimization for Map and list * Minor feedback changes * quick style change

…6fb-1cd3db1d9dd6 [master] Update dependencies from dotnet/arcade

* update runner to netcore runner * build working * release works, start on doc gen * disable docgen until fsharp.formatting is updated and .net core razor available * Add missing manifest file * reenable the linux fcs job * fix bash build script to go to the fcs dir before restore/build * use default targets where appropriate in build definitions * disable macos FCS builds until https://github.com/microsoft/azure-pipelines-image-generation/issues/1351 is merged

* Pick correct dependencies when scripting on coreclr * Look in pack directory for references

* Be very literal about the LangVersion string * Skip timing test

* Fix LinkedSubSource leak in Async.Choice * ref -> mutable

* Fixed literal sig from breaking subsequent sigs * Added tests for literal sig * Fixed test * Fixed test name

* Update dependencies from https://github.com/dotnet/arcade build 20191120.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19570.6 * Update dependencies from https://github.com/dotnet/arcade build 20191121.10 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19571.10 * Update dependencies from https://github.com/dotnet/arcade build 20191122.5 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19572.5 * Update dependencies from https://github.com/dotnet/arcade build 20191123.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19573.1 * Update dependencies from https://github.com/dotnet/arcade build 20191124.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19574.1 * Update dependencies from https://github.com/dotnet/arcade build 20191125.7 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19575.7 * Update dependencies from https://github.com/dotnet/arcade build 20191126.2 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19576.2 * don't publish symbols for tools and proto * Update dependencies from https://github.com/dotnet/arcade build 20191127.4 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19577.4 * Update dependencies from https://github.com/dotnet/arcade build 20191128.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19578.1 * Update dependencies from https://github.com/dotnet/arcade build 20191129.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19579.1 * Update dependencies from https://github.com/dotnet/arcade build 20191130.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19580.1 * Update dependencies from https://github.com/dotnet/arcade build 20191201.1 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19601.1

…202.4 (#7923) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19602.4

…#7919) * fire event when a value is bound at the root of a script evaluation * simplify event notifying bound values in interactive

…elease/dev16.4-to-master

Merge release/dev16.4 to master

…203.17 (#7933) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19603.17

* Remove win32 mmf calls. Use .NET MemoryMappedFile API instead * Use DangerousGetHandle as it's an implementation detail * minor cleanup

nightroman · 2019-12-10T06:23:46Z

@baronfel

Not sure if it is related to this update or my recent VS 16.4 update but on getting packages I see a new warning.

My paket.dependencies:

framework: net461
copy_local: false
references: strict

source https://www.nuget.org/api/v2
nuget FSharp.Compiler.Service
nuget FSharp.Core
nuget System.Collections.Immutable 1.5
nuget System.Reflection.Metadata 1.6

run (you can try in a separate directory with the above paket.dependencies)

paket install

as a result it shows:

Could not detect any platforms from 'netcoreapp3.1' in package System.Reflection.Metadata , please tell the package authors

After that my project builds fine and works as usual.
But the warning is new, I think you might need to know.

baronfel · 2019-12-10T13:04:08Z

What version of paket are you using at the moment?

nightroman · 2019-12-10T13:18:28Z

@baronfel
Yes, my bad, I forgot that paket was involved as well...
With just updated Paket version 5.241.1 the warning is no more. Sorry for the false alarm.

baronfel · 2019-12-10T13:19:16Z

No problem, thank you for being proactive!

brettfo and others added 30 commits August 5, 2019 15:07

update 16.4 version numbers

4f5f083

Merge pull request #7377 from dotnet/merges/release/dev16.3-to-releas…

b384366

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7380 from dotnet/merges/release/dev16.3-to-releas…

0272661

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7393 from dotnet/merges/release/dev16.3-to-releas…

72178fd

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

update build definition to use stages (#7361)

9d2511f

* update build definition to use stages * disable arcade NuGet package validation

upload VSTS drop during internal build (#7392)

00f9cfc

Merge pull request #7402 from brettfo/yaml-updates

275510f

[release/dev16.4] cherry-pick yaml updates to 16.4

Merge pull request #7419 from dotnet/merges/release/dev16.3-to-releas…

0f04f03

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7431 from dotnet/merges/release/dev16.3-to-releas…

88e90ea

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7435 from dotnet/merges/release/dev16.3-to-releas…

f4e7bce

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7439 from dotnet/merges/release/dev16.3-to-releas…

27be414

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7469 from dotnet/merges/release/dev16.3-to-releas…

dbc260c

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

Merge pull request #7496 from dotnet/merges/release/dev16.3-to-releas…

0f7501c

…e/dev16.4 Merge release/dev16.3 to release/dev16.4

[release/dev16.4] Enable auto-insertion creation after signed builds.…

a77767a

… (#7499) * turn off broken source link validation * add VS insertion logic to build pipeline

fix typo (#7501)

1f1efba

update VSSDK to 16.3.2099 (#7528)

e6bb0f1

This fixes an issue where VS Setup was NGENing all of the FSharp.*.resources.dll assemblies.

update insert task to v3 (#7573)

3897909

Relax --noframework for mscorlib, netstandard and system.runtime (#7612)

73f38e4

* Eliminate Relax requirement to apply --noframework when referencing mscorlib/system.runtime.dll/netstandard.dll * Relax requirement to pass --noframework with System.Runtime, netstandard and mscorlib.dll

Merge pull request #7620 from dotnet/merges/master-to-release/dev16.4

0fb5711

Merge master to release/dev16.4

Merge pull request #7624 from dotnet/merges/master-to-release/dev16.4

e8b20b0

Merge master to release/dev16.4

Update dependencies from https://github.com/dotnet/arcade build 20190…

8b3fd3f

…923.5 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19473.5

Fix #7564 (#7596)

f07fcf2

* Add a bind to Parallel test to force async continuations * Fixing Parallel and more tests * Use trampoline holder directly * Split race test to check with and without max degree * Fix RaceBetweenCancellationAndError tests (use an async that errors)

Update dependencies from https://github.com/dotnet/arcade build 20190…

c1cbe09

…926.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19476.6

Merge pull request #7639 from dotnet/merges/master-to-release/dev16.4

969e342

Merge master to release/dev16.4

replace deprecated nuspec iconUrl element with icon

4ee0140

Merge remote-tracking branch 'upstream/darc-master-ccc2f9a8-8c49-40d2…

0bedddc

…-a189-a6dc389f609c' into package-icon

Merge pull request #7655 from brettfo/package-icon

35de30e

replace deprecated nuspec `iconUrl` element with `icon`

delete old build definition file (#7662)

48f932c

Only the 16.3 build uses this file and that branch still has a copy.

update tool requirement to VS 16.3 (#7671)

3fd44c4

dotnet-maestro bot and others added 24 commits December 9, 2019 11:33

Update dependencies from https://github.com/dotnet/arcade build 20191…

75c83a3

…119.6 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19569.6

Fixes #7859 (#7874)

6a07ca9

Minor pickle optimization for Map and list (#7812)

d89d4ff

* Minor pickle optimization for Map and list * Minor feedback changes * quick style change

Merge pull request #7875 from dotnet/darc-master-49f5a84d-0478-420c-9…

16f213a

…6fb-1cd3db1d9dd6 [master] Update dependencies from dotnet/arcade

Remove unnecessary bash script from fcs (#7887)

521a591

Pick correct dependencies when scripting on coreclr (#7889)

917eb4f

* Pick correct dependencies when scripting on coreclr * Look in pack directory for references

enable symbol completion for scripting (#7893)

6c2221f

Be very literal about the LangVersion string (#7895)

cc161ad

* Be very literal about the LangVersion string * Skip timing test

Don't try to print startupRange file contents in debug (#7898)

c0002cc

change the type of completion item returned for scripts (#7899)

8ac99f8

Capitalization (#7908)

9f7f2e5

Fix LinkedSubSource leak in Async.Choice (#7892)

899d210

* Fix LinkedSubSource leak in Async.Choice * ref -> mutable

Fixed Literal value in signature (#7901)

0e3d4d1

* Fixed literal sig from breaking subsequent sigs * Added tests for literal sig * Fixed test * Fixed test name

Update dependencies from https://github.com/dotnet/arcade build 20191…

18b73fb

…202.4 (#7923) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19602.4

fire event when a value is bound at the root of a script evaluation (…

d966659

…#7919) * fire event when a value is bound at the root of a script evaluation * simplify event notifying bound values in interactive

Merge remote-tracking branch 'upstream/release/dev16.4' into merges/r…

ba677fd

…elease/dev16.4-to-master

Merge pull request #7925 from dotnet/merges/release/dev16.4-to-master

40bb7ac

Merge release/dev16.4 to master

Update dependencies from https://github.com/dotnet/arcade build 20191…

11ddd6f

…203.17 (#7933) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19603.17

Use MemoryMappedFile API instead of p/invoke win32 calls (#7944)

1506d3c

* Remove win32 mmf calls. Use .NET MemoryMappedFile API instead * Use DangerousGetHandle as it's an implementation detail * minor cleanup

update CI environments

25db775

update CI builds again

06fb47d

just build only for travis right now

09154cc

baronfel merged commit 7920db8 into fsharp:master Dec 9, 2019

baronfel deleted the integrate-fsharp-again branch December 9, 2019 20:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Integrate dotnet/fsharp from 4f5f08320 to 7b25d7f82 #918

Integrate dotnet/fsharp from 4f5f08320 to 7b25d7f82 #918

Uh oh!

baronfel commented Dec 9, 2019

Uh oh!

nightroman commented Dec 10, 2019

Uh oh!

baronfel commented Dec 10, 2019

Uh oh!

nightroman commented Dec 10, 2019

Uh oh!

baronfel commented Dec 10, 2019

Uh oh!

Uh oh!

Integrate dotnet/fsharp from 4f5f08320 to 7b25d7f82 #918

Integrate dotnet/fsharp from 4f5f08320 to 7b25d7f82 #918

Uh oh!

Conversation

baronfel commented Dec 9, 2019

Uh oh!

nightroman commented Dec 10, 2019

Uh oh!

baronfel commented Dec 10, 2019

Uh oh!

nightroman commented Dec 10, 2019

Uh oh!

baronfel commented Dec 10, 2019

Uh oh!

Uh oh!