feat(ai): data & measurement normalization #4768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
changed the title
loewenheim
reviewed
May 27, 2025
Comment on lines
-1237
to
+1238
| "measurements": { | ||
| "ai_total_tokens_used": { | ||
| "value": 20 | ||
| }, | ||
| "ai_total_cost": { | ||
| "value": 0.0002 | ||
| } | ||
| }, | ||
| "data": { | ||
| "gen_ai.usage.total_tokens": 20, |
There was a problem hiding this comment.
Why is the total cost measurement removed? A corresponding field exists in data, right?
Side note: should we move this test input out of the file? It's literally over 1000 lines long.
There was a problem hiding this comment.
Talk with Anton and apparently that is never send by the SDKs in the first place, so I removed it to keep the test consistent with the real world.
...on/snapshots/relay_server__metrics_extraction__event__tests__both_feature_flags_enabled.snap
Show resolved
Hide resolved
...traction/snapshots/relay_server__metrics_extraction__event__tests__extract_span_metrics.snap
Outdated
Show resolved
Hide resolved
loewenheim
approved these changes
May 27, 2025
Dav1dde
reviewed
May 28, 2025
Comment on lines
+2274
to
+2276
| .and_then(|span| span.value()) | ||
| .and_then(|span| span.data.value()) | ||
| .and_then(|data| data.gen_ai_usage_total_cost.value()), |
Dav1dde
approved these changes
May 28, 2025
…ry/relay into tobias-wilfert/feat/normalize-ai
ArthurKnaus
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 2, 2025
Access span properties via the new keys while also using the old ones as fallback. - part of [TET-498: Trace View - AI Span details](https://linear.app/getsentry/issue/TET-498/trace-view-ai-span-details) - relay started mapping to new keys in getsentry/relay#4768
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jun 2, 2025
Access span properties via the new keys while also using the old ones as fallback. - part of [TET-498: Trace View - AI Span details](https://linear.app/getsentry/issue/TET-498/trace-view-ai-span-details) - relay started mapping to new keys in getsentry/relay#4768
AbhiPrasad
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jun 4, 2025
resolves #16453 In getsentry/sentry-conventions#57 we deprecated some of the `ai.X` attributes in favour of OTEL's `gen_ai.X` attributes. This updates the Vercel AI integration to address these deprecations. These changes are based on https://ai-sdk.dev/docs/ai-sdk-core/telemetry#collected-data, and we created `attributes.ts` to track these as constants. See the relay change here to switch to new attributes for measuring token usage: getsentry/relay#4768
This was referenced Jul 10, 2025
antonpirker
added a commit
to getsentry/sentry-python
that referenced
this pull request
Jul 10, 2025
Store AI token usage in `span.data` instead of deprecated `measurements`. In `relay` there is already code in place that copies the data from the deprecated `span.measurements` to `span.data` and uses `span.data` for calculating the cost of token usage. So this PR can be deployed in a minor without risk. See also `relay` PR: getsentry/relay#4768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps old and depreciated
measurementsanddatato new fields in line with our conventions.Fixes: https://linear.app/getsentry/issue/RELAY-69/normalise-ai-related-span-data
Updates cost calcuation and metric extraction to use
datarather thanmeasurements.Fixes: https://linear.app/getsentry/issue/RELAY-70/update-metrics-extraction-to-new-span-data-names