fix(sveltekit): Avoid capturing redirect() calls as errors in Cloudflare
#16853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/feat-cloudflare-wrapRequestHandler-captureErrors
Lms24
requested review from
s1gr1d,
a team and
andreiborza
and removed request for
a team
Lms24
changed the title
redirect() calls as errors in CloudFlareredirect() calls as errors in Cloudflare
3 tasks
3 tasks
andreiborza
approved these changes
Jul 9, 2025
AbhiPrasad
approved these changes
Jul 9, 2025
Base automatically changed from
lms/feat-cloudflare-wrapRequestHandler-captureErrors
to
develop
July 9, 2025 13:35
Lms24
force-pushed
the
lms/fix-sveltekit-cf-wrapReqHandler-dont-capture-errors
branch
from
b9dd738 to
98d6df2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #16852 to avoid capturing errors too early and too generally via the
initCloudflareSentryHandlerequest handler. Internally, this handler used a wrapper from@sentry/cloudflareto capture errors but prior to #16852 it captured everything that was thrown. This included thrownredirect()objects from SvelteKit which serve as control flow mechanisms but should not be captured as errors.This PR opts out of capturing errors in the Cloudflare wrapper. Instead, we rely on our already existing error capturing mechanisms in SvelteKit, which already ignore
redirect()and a few other error classes.closes #16847