Skip to content

feat(v9/core): Deprecate experimental enableLogs and beforeSendLog option #17092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 21, 2025

Conversation

AbhiPrasad
Copy link
Member

This is the v9 backport of #17063, which deprecates the enableLogs and beforeSendLog under experiments and move it to be top-level options.

@AbhiPrasad AbhiPrasad requested review from andreiborza and a team July 18, 2025 18:39
@AbhiPrasad AbhiPrasad self-assigned this Jul 18, 2025
@AbhiPrasad AbhiPrasad requested review from mydea and removed request for a team July 18, 2025 18:39
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.79 kB +0.05% +10 B 🔺
@sentry/browser - with treeshaking flags 22.35 kB +0.07% +15 B 🔺
@sentry/browser (incl. Tracing) 39.67 kB +0.03% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) 77.8 kB +0.03% +16 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.6 kB +0.02% +11 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 82.5 kB +0.02% +13 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 94.6 kB +0.02% +11 B 🔺
@sentry/browser (incl. Feedback) 40.48 kB +0.02% +7 B 🔺
@sentry/browser (incl. sendFeedback) 28.48 kB +0.05% +12 B 🔺
@sentry/browser (incl. FeedbackAsync) 33.37 kB +0.03% +9 B 🔺
@sentry/react 25.55 kB +0.03% +6 B 🔺
@sentry/react (incl. Tracing) 41.63 kB +0.02% +7 B 🔺
@sentry/vue 28.24 kB +0.03% +7 B 🔺
@sentry/vue (incl. Tracing) 41.45 kB +0.02% +8 B 🔺
@sentry/svelte 23.81 kB +0.04% +8 B 🔺
CDN Bundle 25.18 kB +0.03% +6 B 🔺
CDN Bundle (incl. Tracing) 39.43 kB +0.03% +10 B 🔺
CDN Bundle (incl. Tracing, Replay) 75.42 kB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 80.89 kB +0.01% +5 B 🔺
CDN Bundle - uncompressed 73.45 kB +0.03% +16 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 116.88 kB +0.02% +16 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.01 kB +0.01% +16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.83 kB +0.01% +16 B 🔺
@sentry/nextjs (client) 43.67 kB +0.02% +8 B 🔺
@sentry/sveltekit (client) 40.09 kB +0.03% +10 B 🔺
@sentry/node 169 kB +0.02% +22 B 🔺
@sentry/node - without tracing 100.22 kB +0.02% +20 B 🔺
@sentry/aws-serverless 128.38 kB +0.02% +21 B 🔺

View base workflow run

@AbhiPrasad AbhiPrasad force-pushed the abhi-v9-enable-logs branch from c8722dc to 0757de1 Compare July 18, 2025 19:03
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@AbhiPrasad AbhiPrasad merged commit f402dd2 into v9 Jul 21, 2025
325 of 330 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-v9-enable-logs branch July 21, 2025 08:53
AbhiPrasad added a commit to getsentry/sentry-docs that referenced this pull request Jul 24, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR

Documents getsentry/sentry-javascript#17092

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
lucas-zimerman pushed a commit to getsentry/sentry-docs that referenced this pull request Jul 29, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR

Documents getsentry/sentry-javascript#17092

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
mydea pushed a commit that referenced this pull request Aug 4, 2025
…eedback (#17270)

This is the v9 backport of #17092, which fixes replays created from user
feedback where only the buffered segment is flushed and recording stops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants