Skip to content

ref(sk-update): Add extra description #26869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions static/app/components/events/sdkUpdates/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Alert from 'app/components/alert';
import EventDataSection from 'app/components/events/eventDataSection';
import {IconUpgrade} from 'app/icons';
import {tct} from 'app/locale';
import {t, tct} from 'app/locale';
import {Event} from 'app/types/event';
import getSdkUpdateSuggestion from 'app/utils/getSdkUpdateSuggestion';

Expand All @@ -24,7 +24,9 @@ const SdkUpdates = ({event}: Props) => {

return (
<Alert key={index} type="info" icon={<IconUpgrade />}>
{tct('We recommend you [suggestion]', {suggestion})}
{tct('We recommend you [suggestion] ', {suggestion})}
{sdkUpdate.type === 'updateSdk' &&
t('(All sentry packages should be updated and their versions should match)')}
</Alert>
);
})
Expand Down
10 changes: 10 additions & 0 deletions static/app/components/sidebar/broadcastSdkUpdates.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import styled from '@emotion/styled';
import groupBy from 'lodash/groupBy';

import Alert from 'app/components/alert';
import ProjectBadge from 'app/components/idBadge/projectBadge';
import {IconWarning} from 'app/icons';
import {t} from 'app/locale';
import space from 'app/styles/space';
import {Project, ProjectSdkUpdates, SDKUpdatesSuggestion} from 'app/types';
Expand Down Expand Up @@ -47,6 +49,9 @@ const BroadcastSdkUpdates = ({projects, sdkUpdates}: Props) => {
'Seems like your SDKs could use a refresh. We recommend updating these SDKs to make sure you’re getting all the data you need.'
)}
>
<StyledAlert type="warning" icon={<IconWarning />}>
{t('All sentry packages should be updated and their versions should match.')}
</StyledAlert>
<UpdatesList>
<Collapsible>
{items.map(([projectId, updates]) => {
Expand Down Expand Up @@ -119,4 +124,9 @@ const SdkOutdatedVersion = styled('span')`
color: ${p => p.theme.subText};
`;

const StyledAlert = styled(Alert)`
margin-top: ${space(2)};
margin-bottom: 0;
`;

export default withSdkUpdates(withProjects(BroadcastSdkUpdates));
2 changes: 1 addition & 1 deletion static/app/components/sidebar/sidebarPanelItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const Title = styled('div')<Pick<Props, 'hasSeen'>>`
`;

const Text = styled('div')`
margin-bottom: 5px;
margin-bottom: ${space(0.5)};

&:last-child {
margin-bottom: 0;
Expand Down