Skip to content

build: remove nursery biome rules #64967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,23 @@ module.exports = {
tick: true,
jest: true,
},
parserOptions: {
EXPERIMENTAL_useProjectService: true,
},
rules: {
'react-hooks/exhaustive-deps': [
'warn',
{additionalHooks: ADDITIONAL_HOOKS_TO_CHECK_DEPS_FOR},
],
...(!isRelaxed && !isCi ? strictRulesNotCi : {}),

// TODO(@anonrig): Move this to eslint-config-sentry-app
'@typescript-eslint/consistent-type-imports': [
'error',
{fixStyle: 'separate-type-imports', prefer: 'type-imports'},
],
'@typescript-eslint/consistent-type-exports': ['error'],

// TODO(@anonrig): Remove these rules from eslint-sentry-config.
'import/no-nodejs-modules': 'off',
semi: 'off',
Expand Down
4 changes: 1 addition & 3 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@
},
"nursery": {
"noDuplicateJsonKeys": "error",
"noNodejsModules": "error",
"useExportType": "error",
"useImportType": "error"
"noNodejsModules": "error"
},
"suspicious": {
"noDebugger": "error",
Expand Down
1 change: 0 additions & 1 deletion static/app/components/alerts/onDemandMetricAlert.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import styled from '@emotion/styled';

import Alert from 'sentry/components/alert';
Expand Down
1 change: 0 additions & 1 deletion static/app/components/dropdownAutoComplete/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import {useCallback, useState} from 'react';
import styled from '@emotion/styled';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import {createContext, useContext} from 'react';

import {RELATIVE_DAYS_WINDOW} from 'sentry/components/events/eventStatisticalDetector/consts';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import {Fragment, useEffect, useMemo, useState} from 'react';
import styled from '@emotion/styled';
import startCase from 'lodash/startCase';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type {ReactElement} from 'react';
import type React from 'react';
import {Fragment, useEffect, useLayoutEffect, useMemo, useState} from 'react';
import styled from '@emotion/styled';
import * as Sentry from '@sentry/react';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import {useCallback, useEffect, useMemo, useState} from 'react';
import styled from '@emotion/styled';

Expand Down
2 changes: 0 additions & 2 deletions static/app/utils/onDemandMetrics/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import type React from 'react';

import type {ParseResult, TokenResult} from 'sentry/components/searchSyntax/parser';
import {parseSearch, Token} from 'sentry/components/searchSyntax/parser';
import type {FieldKey} from 'sentry/utils/fields';
Expand Down
1 change: 0 additions & 1 deletion static/app/utils/performance/contexts/pageAlert.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import {createContext, Fragment, useContext, useState} from 'react';
import type {Theme} from '@emotion/react';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type React from 'react';
import styled from '@emotion/styled';

import CircleIndicator from 'sentry/components/circleIndicator';
Expand Down