ref(traces): Remove hiddenAttributes
prop from AttributeTree
#94817
+29
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to simplify some upcoming changes.
AttributeTree
accepts anattributes
prop, and ahiddenAttributes
prop. Any attribute whose name is included inhiddenAttributes
is visually filtered out. This seems strange:AttributeTree
in the trace view, for example, both passesHIDDEN_ATTRIBUTES
and manually omits those fields fromattributes
, I'm not sure whyAttributeTree
, so it's not clear from looking at the component why some things are missing"__sentry"
but not for Staff users), which cannot be expressed viahiddenAttributes
It seems easier and more consistent to remove the
hiddenAttributes
prop, and ensure that the parent component only passes whichever attributes should be omitted.Am I missing something?
Changes
hiddenAttributes