Dataflow: Rename Make to Global and hasFlow to flow #12645
Conversation
github-actions
bot
added
C#
C++
DataFlow Library
documentation
Go
Java
Python
Ruby
Swift
labels
| @@ -233,17 +233,27 @@ module Make<ConfigSig Config> implements DataFlowSig { | |||
| import Impl<C> | |||
| } | |||
|
|
|||
| /** DEPRECATED: Use `Global` instead. */ | |||
| deprecated module Make<ConfigSig Config> implements DataFlowSig { | |||
There was a problem hiding this comment.
Is this still not a breaking change since some of predicates in the DataFlowSig have been renamed?
There was a problem hiding this comment.
The old ones are still available.
There was a problem hiding this comment.
I guess it's breaking if you've written your own parameterised module that relies on DataFlowSig as input, but that signature was primarily meant as documentation.
There was a problem hiding this comment.
Fair enough. That seems unlikely!
| } | ||
|
|
||
| /** | ||
| * Constructs a standard data flow computation. | ||
| */ | ||
| module Make<ConfigSig Config> implements DataFlowSig { | ||
| module Global<ConfigSig Config> implements DataFlowSig { |
There was a problem hiding this comment.
We should probably rename DataFlowSig to GlobalSig?
There was a problem hiding this comment.
I'll rename it to GlobalFlowSig
|
|
||
| /** | ||
| * Holds if data can flow from some source to `sink`. | ||
| */ | ||
| predicate hasFlowToExpr(DataFlowExpr sink); | ||
| predicate flowToExpr(DataFlowExpr sink); | ||
| } | ||
|
|
||
| /** | ||
| * Constructs a standard data flow computation. |
There was a problem hiding this comment.
I think this QL doc should mention global as well.
There was a problem hiding this comment.
Let's do that as followup, I want to merge this ASAP without having to wait for another round of CI.
No description provided.