-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Dataflow: Rename Make to Global and hasFlow to flow #12645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -233,17 +233,27 @@ module Make<ConfigSig Config> implements DataFlowSig { | |||
import Impl<C> | |||
} | |||
|
|||
/** DEPRECATED: Use `Global` instead. */ | |||
deprecated module Make<ConfigSig Config> implements DataFlowSig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still not a breaking change since some of predicates in the DataFlowSig have been renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old ones are still available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's breaking if you've written your own parameterised module that relies on DataFlowSig
as input, but that signature was primarily meant as documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. That seems unlikely!
} | ||
|
||
/** | ||
* Constructs a standard data flow computation. | ||
*/ | ||
module Make<ConfigSig Config> implements DataFlowSig { | ||
module Global<ConfigSig Config> implements DataFlowSig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably rename DataFlowSig
to GlobalSig
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename it to GlobalFlowSig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ 👍
|
||
/** | ||
* Holds if data can flow from some source to `sink`. | ||
*/ | ||
predicate hasFlowToExpr(DataFlowExpr sink); | ||
predicate flowToExpr(DataFlowExpr sink); | ||
} | ||
|
||
/** | ||
* Constructs a standard data flow computation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this QL doc should mention global as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that as followup, I want to merge this ASAP without having to wait for another round of CI.
No description provided.