Shared: Use final aliases in ConcentsShared.qll
#20172
Open
+3
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
shared/concepts-final-aliases
branch
from
9bb87da to
11dcd90
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors CodeQL concept classes to use final type aliases instead of wrapper classes that simply extend and re-expose their base functionality. This follows up on a previous pull request (#19984) by applying the same pattern to ConceptsShared.qll.
- Replaces verbose wrapper classes with concise
finaltype aliases - Removes redundant method forwarding code
- Maintains the same API surface while simplifying implementation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shared/concepts/codeql/concepts/ConceptsShared.qll | Converts CryptographicOperation and Http::Client::Request from wrapper classes to final type aliases |
| javascript/ql/lib/semmle/javascript/Concepts.qll | Converts CryptographicOperation from wrapper class to simple type alias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19984 follow-up.