C++: Don't generate IR for functions with bad ASTs #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change provides a mechanism by which a query can tell the IR package to only create IR for certain functions. This is mostly useful for "PrintIR.qll", which uses this feature to avoid the expense of creating IR for functions that aren't going to be printed.
An slightly invalid AST can cause IR construction to generate extremely bad IR. This change provides a single place to detect invalid ASTs, and to skip IR construction for the affected functions.
jbj
approved these changes
Nov 22, 2018
jbj
added a commit
to jbj/ql
that referenced
this pull request
Nov 22, 2018
This test was failing due to a semantic merge conflict between github#509, which added `UninitializedInstruction`, and github#517, which added new test code that would get `UninitializedInstruction`s in it after merging with github#509.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
…nder-odasa Unify two implementations of GetExtractorPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the IR sanity check failures I've hit when running on real-world snapshots are due to the original ASTs being ill-formed in one way or another. This PR provides a filtering mechanism to avoid generating IR for functions that match an
isInvalidFunctionpredicate, and then implements that predicate to filter out the issues that I already know about. I'll open an individual extractor bug for each of these.See individual commit messages for more detail.