Skip to content

JavaScript: Avoid unhelpful magic. #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2018
Merged

JavaScript: Avoid unhelpful magic. #650

merged 1 commit into from
Dec 10, 2018

Conversation

xiemaisi
Copy link

This was causing SelfAssignment to go wild on anusaaraka (4s -> 693s), and also didn't help on other snapshots.

It's a regression from 1.18, so I'd like to get it in as a (very late) hotfix.

Evaluation on big-apps suggests the fix is otherwise barely noticeable:

azure-sdk-for-node            3808         3606                  0.946954
gecko-dev                     18266        17711                 0.969616
TypeScript                    426          416                   0.976526
mxnet.js                      1280         1261                  0.985156
any-balance-providers         2331         2299                  0.986272
descartes                     2596         2578                  0.993066
angular-gulp-webpack-starter  5079         5095                  1.00315
A2Z-F15                       7009         7056                  1.00671
tatami                        1740         1755                  1.00862
ChakraCore                    4501         4586                  1.01888
node                          6379         6537                  1.02477

@xiemaisi xiemaisi added the JS label Dec 10, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner December 10, 2018 10:44
asger-semmle
asger-semmle approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 57de628 into github:rc/1.19 Dec 10, 2018
@xiemaisi xiemaisi deleted the js/nomagic-isDOMProperty branch January 10, 2019 16:26
@aliscco aliscco mentioned this pull request Feb 23, 2024
Open
@verdinjoshua1982 verdinjoshua1982 mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asger-semmle asger-semmle asger-semmle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiemaisi @asger-semmle @semmle-qlci