feat: Add "Leave GitHub Sponsors" section #5840

Panquesito7 · 2021-04-29T18:15:41Z

Why:

Closes #5780.

What's being changed:

Added a guide for how to leave the GitHub Sponsors program.

Check off the following:

I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
For content changes, I have reviewed the localization checklist
For content changes, I have reviewed the Content style guide for GitHub Docs.

Writer impact (This section is for GitHub staff members only):

This pull request impacts the contribution experience
- I have added the 'writer impact' label
- I have added a description and/or a video demo of the changes below (eg. a "before and after video")

welcome · 2021-04-29T18:15:42Z

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

...in the guides (`content/sponsors/index.md`).

Nikitus-adm

Index

janiceilene · 2021-04-30T23:11:05Z

@Panquesito7 Thanks so much for opening a PR! I'll get this triaged for review ⚡

felicitymay · 2021-05-06T08:43:03Z

Hi @Panquesito7 - thank you so much for taking the time to create this new section of the help.

This is a much more than a simple bug fix and you've also found yourself editing the index.md file that we haven't documented yet! Before I review this PR, I'm going to check in with the team member who's recently reorganized this whole area to check exactly where we should be including these new articles on the landing and guides pages.

jmarlena · 2021-05-07T19:09:07Z

👋🏽 @panquestito7

Thank you for suggesting this and working on this PR!

I'm going to make some updates to the placement of these articles and add a few other updates to fit our styleguide.

Panquesito7 · 2021-05-07T21:20:36Z

Thank you for your help! Hopefully, I did everything correctly. 🙂

jmarlena

@Panquesito7 This is a very impressive first PR! 💪🏽

Since we'd appreciate your contributions more in the future, I've left a few comments to explain the "why" behind some changes I've made. 💖 I hope this context is helpful.

jmarlena · 2021-05-07T22:38:19Z

content/sponsors/leaving-github-sponsors/disabling-your-account.md

+  - /github/supporting-the-open-source-community-with-github-sponsors/disabling-your-github-sponsors-account
+versions:
+  free-pro-team: '*'
+permissions: You can easily leave the GitHub Sponsors program if you no longer want to participate. If some people are sponsoring you, you will need to contact GitHub Support about that.


This statement is generally about who can do what. A permissions statement isn't really needed here since anyone in the GitHub Sponsors program can disable their account. We could mention the caveat about when to contact GitHub Support but I decided to keep that in the article.

For the redirects in line 8: Since this is a new article, we don't actually need redirects. We use redirects when change an article title. But I understand why you'd include this here to copy similar patterns found in other articles

For the redirects in line 8: Since this is a new article, we don't actually need redirects. We use redirects when change an article title. But I understand why you'd include this here to copy similar patterns found in other articles

Well, I actually kept them for that reason, but I'm not really sure if we should remove them. Maybe we should remove them according to what you said. 🙂

I removed them in the commits I made below. 💫

jmarlena · 2021-05-07T22:38:39Z

content/sponsors/leaving-github-sponsors/disabling-your-account.md

+
+### Leaving the GitHub Sponsors program
+
+{% data reusables.sponsors.navigate-to-sponsors-dashboard %}


Great use of reusables here! 💖

jmarlena · 2021-05-07T22:39:01Z

content/sponsors/leaving-github-sponsors/disabling-your-account.md

+
+{% data reusables.sponsors.navigate-to-sponsors-dashboard %}
+{% data reusables.sponsors.settings-tab %}
+{% data reusables.sponsors.disable-your-account %}


Fwiw (for what it's worth), since we only need these steps one time, we don't need a reusable for them. It's great that you know how to create a reusable though! This will come in handy in future scenarios.

jmarlena · 2021-05-07T22:39:58Z

content/sponsors/leaving-github-sponsors/index.md

@@ -0,0 +1,9 @@
+---
+title: Leaving the GitHub Sponsors program


Since the target audience of this article is people who have set up GitHub Sponsors account, we're going to move the content of these two articles into the map topic geared for this specific audience.

jmarlena · 2021-05-07T23:39:39Z

content/sponsors/leaving-github-sponsors/unpublishing-your-account.md

@@ -0,0 +1,20 @@
+---
+title: Unpublishing your GitHub Sponsors account


I changed this title to profile to stay consistent with the UI.

…7/docs into leave_github_sponsors

Panquesito7 · 2021-05-08T00:21:44Z

Any reasons why if you try to search Disabling your GitHub Sponsors account (or similar sentences) it doesn't show up anything? 🤔

Marcin198

Sponsorowane $$

jmarlena · 2021-05-08T00:36:31Z

👋🏽 @Panquesito7

Any reasons why if you try to search Disabling your GitHub Sponsors account (or similar sentences) it doesn't show up anything? 🤔

I'm honestly not sure but let's get this merged in and see if there's still search issues surfacing. Feel free to open an issue if the Search isn't working as expected after this PR merges.

There's some outstanding product questions about the differences between these procedures but to keep this work scoped down and rolling, we're going to merge this for now. 🚂

Thank you for your PR contribution and surfacing this important user need! 😸

Feel free to re-open a PR for any follow-up.

For instance, for these steps there's usually another header above this section that we use when we say:

Under "[subheader]", click button.

But I wasn't able to check this UI so this might be the only subheader.

felicitymay · 2021-05-08T00:43:51Z

Any reasons why if you try to search Disabling your GitHub Sponsors account (or similar sentences) it doesn't show up anything?

I'm fairly sure that the staging previews just use the search index from the live site, and don't index the preview. So your new article won't appear in search results until the pull request is merged and the index recalculated. This may take a few minutes.

jmarlena

🚢

github-actions · 2021-05-08T00:45:55Z

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Panquesito7 · 2021-05-09T13:16:39Z

Hey, GitHub team! I've seen the changes are not still there. Do we still have to wait more time, or is there something we should do? Thank you. 🙂

felicitymay · 2021-05-10T07:07:23Z

Hey, GitHub team! I've seen the changes are not still there. Do we still have to wait more time, or is there something we should do? Thank you. 🙂

🤔 Your new articles should have been live a while back, I'll check with our engineering team as it sounds like a deployment bug.

Panquesito7 · 2021-05-10T15:43:18Z

should have been live a while back

This PR should fix it I think #6195.

felicitymay · 2021-05-10T17:38:44Z

The docs engineering team fixed the problem.

🚀 https://docs.github.com/en/sponsors/receiving-sponsorships-through-github-sponsors/disabling-your-github-sponsors-account and https://docs.github.com/en/sponsors/receiving-sponsorships-through-github-sponsors/unpublishing-your-github-sponsors-profile are now live and findable in the search 😄

Thanks for your patience ✨

feat: Add "Leave GitHub Sponsors" section

1b940d0

github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 29, 2021

feat: Add Leaving the GitHub Sponsors program...

de82071

...in the guides (`content/sponsors/index.md`).

Panquesito7 force-pushed the leave_github_sponsors branch from f921b32 to de82071 Compare April 29, 2021 18:36

fix: Minor improvement/fix

0b905bc

Nikitus-adm reviewed Apr 30, 2021

View reviewed changes

janiceilene added sponsors Content related to GitHub Sponsors waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 30, 2021

felicitymay self-assigned this May 6, 2021

janiceilene added the guide label May 7, 2021

jmarlena and others added 2 commits May 7, 2021 16:35

Merge branch 'main' into leave_github_sponsors

6829b96

Merge branch 'main' into leave_github_sponsors

66ef7ed

jmarlena reviewed May 7, 2021

View reviewed changes

jmarlena added 6 commits May 7, 2021 16:44

Condense into existing category and apply some styleguide edits

571ffd5

Include disabling procedure

9b5f4ea

Merge branch 'leave_github_sponsors' of https://github.com/Panquesito…

e807328

…7/docs into leave_github_sponsors

Standardize frontmatter

ad2d138

Mention UI copy about requesting to re-publish profile

b8209ef

Less certain about timing

a1f7974

felicitymay assigned jmarlena and unassigned felicitymay May 8, 2021

Marcin198 previously approved these changes May 8, 2021

View reviewed changes

Fix link

505f20f

jmarlena dismissed Marcin198’s stale review via 505f20f May 8, 2021 00:25

Merge branch 'main' into leave_github_sponsors

a880b91

Marcin198 approved these changes May 8, 2021

View reviewed changes

jmarlena approved these changes May 8, 2021

View reviewed changes

jmarlena merged commit 7b99fd0 into github:main May 8, 2021

Panquesito7 deleted the leave_github_sponsors branch May 8, 2021 04:37

Panquesito7 mentioned this pull request May 9, 2021

Minor typo in the Unpublishing your GitHub Sponsors profile guide #6194

Closed


		### Leaving the GitHub Sponsors program

		{% data reusables.sponsors.navigate-to-sponsors-dashboard %}

		@@ -0,0 +1,9 @@
		---
		title: Leaving the GitHub Sponsors program

		@@ -0,0 +1,20 @@
		---
		title: Unpublishing your GitHub Sponsors account

feat: Add "Leave GitHub Sponsors" section #5840

feat: Add "Leave GitHub Sponsors" section #5840

Uh oh!

Conversation

Panquesito7 commented Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

What's being changed:

Check off the following:

Writer impact (This section is for GitHub staff members only):

Uh oh!

welcome bot commented Apr 29, 2021

Uh oh!

Nikitus-adm left a comment

Choose a reason for hiding this comment

Uh oh!

janiceilene commented Apr 30, 2021

Uh oh!

felicitymay commented May 6, 2021

Uh oh!

jmarlena commented May 7, 2021

Uh oh!

Panquesito7 commented May 7, 2021

Uh oh!

jmarlena left a comment

Choose a reason for hiding this comment

Uh oh!

jmarlena May 7, 2021

Choose a reason for hiding this comment

Uh oh!

jmarlena May 7, 2021

Choose a reason for hiding this comment

Uh oh!

Panquesito7 May 8, 2021

Choose a reason for hiding this comment

Uh oh!

jmarlena May 8, 2021

Choose a reason for hiding this comment

Uh oh!

jmarlena May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarlena May 7, 2021

Choose a reason for hiding this comment

Uh oh!

jmarlena May 7, 2021

Choose a reason for hiding this comment

Uh oh!

jmarlena May 7, 2021

Choose a reason for hiding this comment

Uh oh!

Panquesito7 commented May 8, 2021

Uh oh!

Marcin198 left a comment

Choose a reason for hiding this comment

Uh oh!

jmarlena commented May 8, 2021

Uh oh!

felicitymay commented May 8, 2021

Uh oh!

jmarlena left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

Panquesito7 commented May 9, 2021

Uh oh!

felicitymay commented May 10, 2021

Uh oh!

Panquesito7 commented May 10, 2021

Uh oh!

felicitymay commented May 10, 2021

Uh oh!

Uh oh!

Panquesito7 commented Apr 29, 2021 •

edited

Loading

jmarlena May 7, 2021 •

edited

Loading