Discussion comment notification does not point to the comment.

[wkjung]

🔍 Is there already an issue for your problem?

• I have checked older issues, open and closed

📝 Description

If I click a gift notification by other commenter's reply in a discussion, it doesn't directly go to the comment.
Instead it redirects me to Discussion tab page (i.e. https://<ghes-url>/<org>/<repo>/discussions).
Which means I manually have to find out what exact discussion has a comment that notified me.

I found out that that it is because #discussioncomment-<sum-number> is missing in the gitify notification.
When I click a notification in Github (GHES)'s Notification page, the link url is like

https://<ghes-url>/<org>/<repo>/discussions/15?notification_referrer_id=MDE4Ok5vdGlmaWNhdGlvblRocmVhZDE5NDQzNzEwOjk2OTAw#discussioncomment-13072

which redirects me to the correct comment.

BUT the same notification in gitify is missing the said #discussioncomment:

https://<ghes-url>/<org>/<repo>/discussions/15?notification_referrer_id=MDE4Ok5vdGlmaWNhdGlvblRocmVhZDE5NDQzNzEwOjk2OTAw

btw our corporate is using GitHub Enterprise Server 3.11.15.

🪜 Steps To Reproduce

(in GHES)

1. Make another person to reply to any discussion that I am in the thread. Get 'commented' notification.
2. Gitify notifies me, so click the notification.
3. It drops me off at <org>/<repo>/<discussion> page, not to the specific discussion's comment.

Gitify Version

5.16.2

Operating System

macOS

GitHub Account

GitHub Cloud

📸 Screenshots

No response

[setchy]

And is there anything in the application logs when clicking on a discussion?

Seems like for your specific setup this is returning null / throwing an error

https://github.com/gitify-app/gitify/blob/main/src%2Frenderer%2Futils%2Fhelpers.ts#L102-116

[wkjung]

This is app log when I did below:

• click the refresh button in Gitify to show discussion comment notification
• click on the notification

[2024-11-27 13:40:35.468] [error] Error occurred while fetching notification latest discussion TypeError: Cannot read properties of undefined (reading 'search')
    at t.getLatestDiscussion (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:2:422946)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:23737
    at async t.getGitifySubjectDetails (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:23705)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:19491
    at async Promise.all (index 0)
    at async g (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:19441)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:17927
    at async Promise.all (index 0)
    at async t.getAllNotifications (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:17790)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:2:403194
[2024-11-27 13:40:35.469] [error] Error occurred while fetching details for Discussion notification:<corporate-discussion-name> TypeError: Cannot read properties of undefined (reading 'comments')
    at file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:23863
    at async t.getGitifySubjectDetails (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:23705)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:19491
    at async Promise.all (index 0)
    at async g (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:19441)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:17927
    at async Promise.all (index 0)
    at async t.getAllNotifications (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:17790)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:2:403194
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:2:401688
[2024-11-27 13:40:52.364] [error] Error occurred while fetching notification latest discussion TypeError: Cannot read properties of undefined (reading 'search')
    at t.getLatestDiscussion (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:2:422946)
    at async file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:11832
    at async t.generateGitHubWebUrl (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:11734)
    at async t.openNotification (file:///Applications/Gitify.app/Contents/Resources/app.asar/build/renderer.js:60:17190)

btw I use PAT with ALL permissions checked, just in case you know.

[setchy]

Thanks, this is helpful.

I would suggest next steps be running the app from source locally and debug why the GraphQL query response fails

[wkjung]

how can I get the graphql query response? sorry Im kinda new

…

Thanks, this is helpful. I would suggest next steps be running the app from source locally and debug why the GraphQL query response fails — Reply to this email directly, view it on GitHub <#1645 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJPZNRHUCHMQ7QLRWMGSIOD2CWN5NAVCNFSM6AAAAABSPQK7HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTGUYTOMZXGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[setchy]

@wkjung - you have a few options.

You can follow the debug faq instructions located here: https://gitify.io/faq/ - within the network tab of the embedded browser you'll be able to inspect the graphql requests.

Alternatively, you could run Gitify from source and debug

gitify/src/renderer/utils/helpers.ts

Lines 102 to 119 in a34087b

	async function getDiscussionUrl(notification: Notification): Promise<Link> {
	const url = new URL(notification.repository.html_url);
	url.pathname += '/discussions';
	const discussion = await getLatestDiscussion(notification);
	if (discussion) {
	url.href = discussion.url;
	const latestComment = getLatestDiscussionComment(discussion.comments.nodes);
	if (latestComment) {
	url.hash = `#discussioncomment-${latestComment.databaseId}`;
	}
	}
	return url.toString() as Link;
	}

[wkjung]

After checking the graphQL query and its response, found that the issue is from GHES version; 3.11 does not have isAnswered field in discussion. It was added in 3.12.

Query

query fetchDiscussions($queryStatement: String!, $firstDiscussions: Int, $lastComments: Int, $lastReplies: Int) { 
  search(query: $queryStatement, type: DISCUSSION, first: $firstDiscussions) { 
    nodes { 
      ... on Discussion { 
        number 
        title 
        stateReason 
        isAnswered 
        url 
        author { 
          ...AuthorFields 
        } 
        comments(last: $lastComments) { 
          totalCount 
          nodes { 
            ...CommentFields 
            replies(last: $lastReplies) { 
              nodes { 
                ...CommentFields 
              } 
            } 
          } 
        } 
        labels { 
          nodes { 
            name 
          } 
        } 
      } 
    } 
  } 
} 
 
fragment AuthorFields on Actor { 
  login 
  url 
  avatar_url: avatarUrl 
  type: __typename 
} 
 
fragment CommentFields on DiscussionComment { 
  databaseId 
  createdAt 
  author { 
    ...AuthorFields 
  } 
} 

Response

{ 
    "errors": [ 
        { 
            "path": [ 
                "query fetchDiscussions", 
                "search", 
                "nodes", 
                "... on Discussion", 
                "isAnswered" 
            ], 
            "extensions": { 
                "code": "undefinedField", 
                "typeName": "Discussion", 
                "fieldName": "isAnswered" 
            }, 
            "locations": [ 
                { 
                    "line": 8, 
                    "column": 9 
                } 
            ], 
            "message": "Field 'isAnswered' doesn't exist on type 'Discussion'" 
        } 
    ] 
}

[setchy]

Thanks @wkjung - this is helpful. If you have a few moments could you kindly test this fix with your environment - #1665

[jkbe]

I have a similar issue where I click the Gitify notification for a reply to a PR review and the URL fragment #discussion_r01234567890 is missing from the opened link. Does anyone have an idea what could be the problem?

I checked the Gitify logs but there are no errors. The repos that his occurs for are from a github.com organization on the Team plan if this helps. I'm using latest Gitify v5.17.0.

[setchy]

@JakobEdding - can you confirm if you have the Detailed notifications appearance setting enabled?

[jkbe]

Yes, I have that enabled. I saw that there is a hint about many unread notifications next to that setting. I assume my case of having ~120 notifications of which ~15 are unread shouldn't be an issue?