process timeouts and some refactoring #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Code is clearer now. |
alexandresalome
pushed a commit
that referenced
this pull request
Feb 7, 2014
process timeouts and some refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
My manager asked me to do some kind of report: calculate statistics about commits per user in our company. Github API has request limit that is not enough for me so I wrote small script to do all work on local computer (clone, iterate commits and so on). But I wanted to speed up my script by running it in many parallel processes (one per repository). And some of reposiitories were large. So, script was throwing exceptions that process exceeded timeout of 60 seconds.
When I tried to fix this I have found some copypaste, so I have done small refactoring.
All tests pass, so please have a look at this fix.
Thanks in advance.