Skip to content

1751 follow symlink for keybinding config #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2023
Merged

1751 follow symlink for keybinding config #1767

merged 4 commits into from
Jul 29, 2023

Conversation

TheBlackSheep3
Copy link
Contributor

@TheBlackSheep3 TheBlackSheep3 commented Jul 22, 2023

This Pull Request fixes/closes #1751.

It changes the following:

  • follow symlinks for key_bindings.ron and key_symbols.ron

I followed the checklist:

  • I added unittests
  • I ran make check without errors (macos)
  • I ran make check without errors (windows)
  • I ran make check without errors (linux)
  • I tested the overall application
  • I added an appropriate item to the changelog

@TheBlackSheep3
Copy link
Contributor Author

I'm not sure if symlinks for themes should be supported as well. Let me hear your thoughts on this.

I can add it as part of this PR as well if you want.

@TheBlackSheep3
Copy link
Contributor Author

My bad, I forgot to write the windows symlink test. I'll add it asap.

@extrawurst extrawurst merged commit 104e5bf into gitui-org:master Jul 29, 2023
@extrawurst
Copy link
Collaborator

extrawurst commented Jul 29, 2023

Thanks ❤️

@TheBlackSheep3 TheBlackSheep3 deleted the 1751-follow-symlink-for-keybinding-config branch July 30, 2023 06:37
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key_bindings.ron should follow symlink
2 participants