NoReply Address Always Dummy Address Regardless of Root URL Domain

[bagasme]

• Gitea version (or commit ref): 1.9.0
• Git version: 2.17.1
• Operating system: Ubuntu 18.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:
  (not relevant)

Description

Installing Gitea set NO_REPLY_ADDRESS option on app.ini to dummy noreply@example.org address, regardless of domain in ROOT_URL. For NoReply emails to function correctly, use address from same domain as in ROOT_URL. For example, if ROOT_URL domain is mygitea.instance, NO_REPLY_ADDRESS should be noreply@mygitea.instance.

Screenshots

(not relevant)

[bagasme]

@lunny I think kind/docs label isn't appropriate here, as this issue is about configuration.

[zeripath]

If I understand you correctly You mean to say that on this line:

gitea/modules/setting/service.go

Line 86 in 01a4a7c

Service.NoReplyAddress = sec.Key("NO_REPLY_ADDRESS").MustString("noreply.example.org")

You think the default should be:

Service.NoReplyAddress = sec.Key("NO_REPLY_ADDRESS").MustString(Domain)

You would need to update:

gitea/custom/conf/app.ini.sample

Line 507 in ee7df7b

NO_REPLY_ADDRESS = noreply.example.org

NO_REPLY_ADDRESS = %(DOMAIN)s

And it would be helpful to add a description in to https://github.com/go-gitea/gitea/blob/master/docs/content/doc/advanced/config-cheat-sheet.en-us.md#service-service as this option is not documented there.

[bagasme]

@zeripath what's purpose of %(DOMAIN)s?

[zeripath]

It's just to document that the default value is the string value of DOMAIN

[bagasme]

OK, but I'd like to assign this issue to someone else instead. I'm just contributing to Gitea by reporting issues (currently).

[bagasme]

@zeripath thanks for the PR