Skip to content

lint: fix usetesting issues #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025

Conversation

alexandear
Copy link
Contributor

Tested on Windows — it works as expected.

@alexandear alexandear force-pushed the lint-fix-usetesting branch from 9902c31 to b8bde8c Compare August 4, 2025 15:44
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.76%. Comparing base (a5c0582) to head (ead86d4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          40       40           
  Lines        1920     1920           
=======================================
  Hits         1781     1781           
  Misses        114      114           
  Partials       25       25           
Flag Coverage Δ
oldstable-macos-latest 91.56% <ø> (ø)
oldstable-ubuntu-latest 91.56% <ø> (ø)
oldstable-windows-latest 92.76% <ø> (ø)
stable-macos-latest 91.56% <ø> (ø)
stable-ubuntu-latest 91.56% <ø> (ø)
stable-windows-latest 92.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandear alexandear changed the title lint: fix usetesting issue lint: fix usetesting issues Aug 4, 2025
Signed-off-by: Oleksandr Redko <[email protected]>
@alexandear alexandear force-pushed the lint-fix-usetesting branch from b8bde8c to ead86d4 Compare August 4, 2025 15:50
Copy link
Member

@fredbi fredbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know that this has been fixed on windows.
There are some other go-openapi repos with the same need. Thanks for letting me know.

Fred

@fredbi fredbi merged commit 14e1493 into go-openapi:master Aug 9, 2025
11 checks passed
@fredbi
Copy link
Member

fredbi commented Aug 9, 2025

@alexandear looks like it doesn't really work as expected, even though it looks like it does in this repo.
See go-openapi/analysis#125. Propagated the same fix, but different conditions (e.g. racing).

@fredbi
Copy link
Member

fredbi commented Aug 9, 2025

The original go issue () is still open AFAIK: golang/go#71544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants