feat: Add translateByVector2 method to Matrix4 #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the deprecation of the dynamic
translate
method, since thez
variable had default value of0
, you could translate by a vector two by doing:Here is an example "in the wild" of such usage.
With the new methods, this becomes even less ergonomic, as it would require either calling
translateByDouble
with 2 extra parameters, or converting theVector2
to aVector3
.So I propose we introduce a
translateByVector2
which behaves exactly astranslate(x, y)
would before.