Skip to content

Prettier setup #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 31, 2018
Merged

Prettier setup #165

merged 7 commits into from
Oct 31, 2018

Conversation

maxymshg
Copy link
Contributor

@maxymshg maxymshg commented Oct 6, 2018

No description provided.

@h-michael
Copy link
Member

we can use multiple language with Travis like this.

language: rust, node_js

@maxymshg
Copy link
Contributor Author

maxymshg commented Oct 7, 2018

@h-michael , Thank you.

I looked over TravicCI docs for something like this, but not found anything except simple apt install to get nodejs.

@maxymshg
Copy link
Contributor Author

maxymshg commented Oct 7, 2018

@h-michael , Could you please share the link to the documentation where you find this info? I tried and it's failed for me.

@h-michael
Copy link
Member

@maxymshg
Sorry, my info seems to be old.
Now, your way seems to be right.
https://docs.travis-ci.com/user/customizing-the-build/#installing-a-second-programming-language

@h-michael
Copy link
Member

@maxymshg
Could you apply prettier to existing queries?

@h-michael
Copy link
Member

You should update CONTRIBUTING.md with how to install prettier, how to apply prettier.

@maxymshg
Copy link
Contributor Author

maxymshg commented Oct 8, 2018

Ok, thank you. I'll update CONTRIBUTING.md soon.

Could you apply prettier to existing queries?

I already run prettier over .json, .graphql files. What else I missed?

@h-michael
Copy link
Member

It seems that CI failed because of returned exit 1 by prettier.

@maxymshg
Copy link
Contributor Author

maxymshg commented Oct 9, 2018

Yes, I think it's because of this: prettier/prettier#4144 (comment)

@maxymshg
Copy link
Contributor Author

I've updated CONTRIBUTING.md. What we should do with this fail from prettier?

@maxymshg
Copy link
Contributor Author

@h-michael or @tomhoule, Could you please assist with next steps?

@tomhoule
Copy link
Member

Sorry for the late review! It's a very busy week. The current setup looks great, thanks for the PR! I think it fails as it should already. If you run prettier once with --write the build should pass, right?

@h-michael
Copy link
Member

@maxymshg
I create PR to this branch.
After merging it, you can get exit status 0.

@maxymshg
Copy link
Contributor Author

Thank you for support, PR merged.

@h-michael
Copy link
Member

h-michael commented Oct 21, 2018

@tomhoule
Now, pass the CI. 🎉

@maxymshg maxymshg changed the title WIP: Prettier setup Prettier setup Oct 21, 2018
@h-michael
Copy link
Member

@tomhoule
Would you resolve conflicts?

@tomhoule
Copy link
Member

@h-michael done, let's merge as soon as it passes CI.

@tomhoule tomhoule merged commit 6c5c3db into graphql-rust:master Oct 31, 2018
@maxymshg maxymshg deleted the add-prettier branch October 31, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants