-
Notifications
You must be signed in to change notification settings - Fork 163
Prettier setup #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier setup #165
Conversation
we can use multiple language with Travis like this.
|
@h-michael , Thank you. I looked over TravicCI docs for something like this, but not found anything except simple |
@h-michael , Could you please share the link to the documentation where you find this info? I tried and it's failed for me. |
@maxymshg |
@maxymshg |
You should update CONTRIBUTING.md with how to install prettier, how to apply prettier. |
Ok, thank you. I'll update CONTRIBUTING.md soon.
I already run prettier over |
It seems that CI failed because of returned exit 1 by prettier. |
Yes, I think it's because of this: prettier/prettier#4144 (comment) |
I've updated CONTRIBUTING.md. What we should do with this fail from prettier? |
@h-michael or @tomhoule, Could you please assist with next steps? |
Sorry for the late review! It's a very busy week. The current setup looks great, thanks for the PR! I think it fails as it should already. If you run prettier once with |
Use multiple language support
added section with prettier setup instructions.
6e508be
to
9ec9da1
Compare
Thank you for support, PR merged. |
@tomhoule |
@tomhoule |
@h-michael done, let's merge as soon as it passes CI. |
No description provided.