Skip to content

fix(docs/mutations-and-input-types.mdx): root being inside of SDL #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

alesculek
Copy link
Contributor

@alesculek alesculek commented Jul 7, 2025

The example shows graphql implementation, where the "root" is by mistake put as string as part of the schema definition instead being a native js const

BEFORE (root is undefined and wongly put into the schema itself):

image

AFTER (root correctly defined outside of the schema):

image

@alesculek alesculek requested a review from a team as a code owner July 7, 2025 11:01
Copy link

linux-foundation-easycla bot commented Jul 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alesculek / name: Aleš Culek (e5f7b4f)

@yaacovCR
Copy link
Contributor

yaacovCR commented Jul 7, 2025

If you have time to fix the indentation, that would be great also

@alesculek
Copy link
Contributor Author

Sure, I will fix indentation and typo "DSL" -> "SDL" (and rebase if needed)

The example shows graphql SDL implementation, where the "root" is by mistake put as string as part of the schema definition instead being a native js const
@alesculek alesculek changed the title Fix root being inside of DSL in mutations-and-input-types.mdx fix(docs/mutations-and-input-types.mdx): root being inside of SDL Jul 8, 2025
@alesculek
Copy link
Contributor Author

@yaacovCR addressed, should be fine now.

@JoviDeCroock JoviDeCroock merged commit 8dc2955 into graphql:16.x.x Jul 8, 2025
20 checks passed
@alesculek alesculek deleted the patch-1 branch July 16, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants