2020-11 monthly release

[alanz]

Is there any reason we should not start preparing to tag a new release?

[wz1000]

It would be good to have #530 in

[jneira]

Maybe we should release a new version of hls-plugin-api but it needs a ghcide release

[alanz]

So, things are getting more complicated. What has changed in the hls-plugin-api?

[jneira]

@alanz not a big thing, it now exposes client settings as a shake action (it is used by hlint plugin)

diff --git a/hls-plugin-api/src/Ide/Plugin.hs b/hls-plugin-api/src/Ide/Plugin.hs
index 1ef7c3e..e509196 100644
--- a/hls-plugin-api/src/Ide/Plugin.hs
+++ b/hls-plugin-api/src/Ide/Plugin.hs
@@ -12,10 +12,13 @@ module Ide.Plugin
       asGhcIdePlugin
     , pluginDescToIdePlugins
     , mkLspCommand
+    , mkLspCmdId
     , allLspCmdIds
     , allLspCmdIds'
     , getPid
     , responseError
+    , getClientConfig
+    , getClientConfigAction
     ) where

 import           Control.Exception(SomeException, catch)
@@ -24,6 +27,7 @@ import           Control.Monad
 import qualified Data.Aeson as J
 import qualified Data.Default
 import           Data.Either
+import           Data.Hashable (unhashed)
 import qualified Data.List                     as List
 import qualified Data.Map  as Map
 import           Data.Maybe
@@ -31,6 +35,7 @@ import qualified Data.Text                     as T
 import           Development.IDE   hiding (pluginRules)
 import           Development.IDE.LSP.Server
 import           GHC.Generics
+import           Ide.Logger
 import           Ide.Plugin.Config
 import           Ide.Plugin.Formatter
 import           Ide.Types
@@ -587,4 +592,13 @@ getPrefixAtPos lf uri pos = do
 getClientConfig :: LSP.LspFuncs Config -> IO Config
 getClientConfig lf = fromMaybe Data.Default.def <$> LSP.config lf

+-- | Returns the client configurarion stored in the IdeState.
+-- You can use this function to access it from shake Rules
+getClientConfigAction :: Action Config
+getClientConfigAction = do
+  mbVal <- unhashed <$> useNoFile_ GetClientSettings
+  logm $ "getClientConfigAction:clientSettings:" ++ show mbVal
+  case J.fromJSON <$> mbVal of
+    Just (J.Success c) -> return c
+    _ -> return Data.Default.def

Imo it is not needed to release haskell-language-server and it should not block the monthly release

[alanz]

So what happens with the hlint plugin then? It's one of the big deals in the current version.

[jneira]

hlint uses the git submodule version so it will work.
The released version is supposed to be used by external plugins and i am not aware of nobody doing it (there is 79 downloads in hackage though).
Otoh the change is mainly an addition, no api breaking changes so it is not a big deal

[alanz]

So, are we doing this? Is everything merged that we want?

[jneira]

I hope this night will be able to merge the last ghcide bump