Skip to content

failed tasty tests are errors #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2018
Merged

failed tasty tests are errors #1609

merged 2 commits into from
Sep 11, 2018

Conversation

fommil
Copy link
Contributor

@fommil fommil commented Sep 1, 2018 •
edited
Loading

follow up to #1608 (ansi colours included in this screenshot to show them playing well together)

Note that next-error (i.e. jump to error) works as expected... and everything you see that is underlined is clickable, if you are so inclined as to use something as clumsy as a mouse 😝

2018-09-02-005739_1918x1078_scrot

@fommil
Copy link
Contributor Author

fommil commented Sep 2, 2018

Unfortunately this doesn't catch this sort of failure

  FAIL
        test/Course/StateTest.hs:91:
        expected: (Full 'c',3)
         but got: (Full 'c',8)
      find 'i' in 'a'..'h':

@fommil
Copy link
Contributor Author

fommil commented Sep 2, 2018

latest commit should address that

@purcell purcell merged commit 95c970a into haskell:master Sep 11, 2018
@purcell
Copy link
Member

purcell commented Sep 11, 2018

Thanks!~

@fommil fommil deleted the tasty-warnings branch September 11, 2018 10:34
@fommil fommil mentioned this pull request Dec 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fommil @purcell