Bugfix: Update for regex 20 lookbehind test. #1407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed cpp file and added cpp2 file.
There seems to be a problem for MSVC here with "cpp2regex.h2(591): error C2668: 'std::make_reverse_iterator': ambiguous call to overloaded function". Here's 591:
r := func(make_reverse_iterator(cur), make_reverse_match_context(ctx), true_end_func());
It seems the similar line 577 should also get this error, but doesn't because maybe that one is never invoked?
Conjecture: Maybe
- lines 577 and 591 make*iterator calls should be std:: qualified, and
- the make*iterator helpers on lines 184-189 should just be removed as they don't seem to be used?
But I'm not sure so I'll just push this update to regression tests in without any code changes
|
Thanks! I pushed a commit that re-runs the regression tests to keep everything in sync. While doing that, I noticed there seems to be a problem for MSVC here with It seems the similar line 577 should also get this error, but doesn't because maybe that one is never invoked? Conjecture: Maybe
But I'm not sure so I just pushed the update to regression tests in without any code changes. |
|
I will have a look during the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed cpp file and added cpp2 file.