Add QUIC traits #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindSoilder
reviewed
Jul 31, 2020
stammw
reviewed
Jul 31, 2020
This adds a `quic` module with a few traits, which can be used to abstract over the QUIC transport.
stammw
approved these changes
Aug 2, 2020
stammw
reviewed
Aug 2, 2020
| /// When the receive side will no longer receive more data (such as because | ||
| /// the peer closed their sending side), this should return `None`. | ||
| fn poll_data( | ||
| &mut self, |
There was a problem hiding this comment.
Should we make this Pin<> right now?
There was a problem hiding this comment.
The tricky part is, if this requires Pin, then how about the methods that wouldn't normally, such as stop_sending? That method itself likely doesn't need to be pinned, but once you've pinned to call poll_data, you can't easily unpin (generically) to fulfill &mut self... I don't know what the right answer is.
stammw
pushed a commit
that referenced
this pull request
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
quicmodule with a few traits, which can be used toabstract over the QUIC transport.