Skip to content

[Snyk] Security upgrade @hyperledger/firefly-sdk from 1.2.7 to 1.3.0 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwagantall
Copy link

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • combined/mint-token-on-public-ethereum-network/package.json
  • combined/mint-token-on-public-ethereum-network/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9292519
  631  
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9403194
  524  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Server-side Request Forgery (SSRF)

…mbined/mint-token-on-public-ethereum-network/package-lock.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-AXIOS-9292519
- https://snyk.io/vuln/SNYK-JS-AXIOS-9403194

Signed-off-by: Ry Jones <[email protected]>
@ryjones ryjones force-pushed the snyk-fix-b0ff40449ad8cf5df3c83bbe0903e371 branch from 29805c0 to 675afc5 Compare June 30, 2025 13:18
@ryjones ryjones requested a review from a team June 30, 2025 13:22
@EnriqueL8
Copy link
Contributor

This needs to be fixed

❯ npm run build

> [email protected] build
> tsc

node_modules/axios/index.d.ts:364:23 - error TS2304: Cannot find name 'RequestInit'.

364   fetchOptions?: Omit<RequestInit, 'body' | 'headers' | 'method' | 'signal'> | Record<string, any>;
                          ~~~~~~~~~~~

src/main.ts:49:15 - error TS2339: Property 'tx' does not exist on type 'FireFlyEventDelivery | FireFlyEventBatchDelivery'.
  Property 'tx' does not exist on type 'FireFlyEventBatchDelivery'.

49     tx: event.tx,
                 ~~

@EnriqueL8
Copy link
Contributor

EnriqueL8 commented Jul 2, 2025

Upgrading this version changed the API above so it's not a simple bump of vulnerability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants