Skip to content

fix: Adding the missing module #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2021
Merged

fix: Adding the missing module #1004

merged 3 commits into from
Jul 19, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 18, 2021

Description

Please include a summary of the change, motivation and context.
fix: Adding the missing module

Due to this time range is not showing up

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner July 18, 2021 05:56
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #1004 (c31c28d) into main (185c6fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         820      820           
  Lines       16855    16856    +1     
  Branches     2190     2190           
=======================================
+ Hits        14336    14337    +1     
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...rc/header/application/application-header.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185c6fd...c31c28d. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 3b2f84b into main Jul 19, 2021
@anandtiwary anandtiwary deleted the fix-time-range branch July 19, 2021 04:10
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   15m 57s ⏱️ +55s
944 tests ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
951 runs  ±0  951 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b2f84b. ± Comparison against base commit 185c6fd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants