Skip to content

fix: topology error fix due to change in metrics model #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 19, 2021

Conversation

itssharmasandeep
Copy link
Contributor

Testing

Local Testing done.

Checklist:

  • My changes generate no new warnings

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner July 19, 2021 11:37
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #1005 (1403cb5) into main (3b2f84b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   85.05%   85.06%           
=======================================
  Files         820      820           
  Lines       16856    16862    +6     
  Branches     2190     2190           
=======================================
+ Hits        14337    14343    +6     
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...apis/api-detail/overview/api-overview.dashboard.ts 100.00% <100.00%> (ø)
...vice-detail/overview/service-overview.dashboard.ts 100.00% <100.00%> (ø)
projects/observability/src/public-api.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b2f84b...1403cb5. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 3f829c6 into main Jul 19, 2021
@itssharmasandeep itssharmasandeep deleted the topology-fix branch July 19, 2021 12:09
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   16m 25s ⏱️ +28s
944 tests ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
951 runs  ±0  951 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3f829c6. ± Comparison against base commit 3b2f84b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants