Skip to content

fix: tab design fix #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2021
Merged

fix: tab design fix #1012

merged 6 commits into from
Jul 20, 2021

Conversation

itssharmasandeep
Copy link
Contributor

Description

  • Removing blue ink bar from non navigable tabs
  • Removing blue hover color from navigable tabs
  • Changing hover color for non active tabs to selected color($gray-9)

Testing

Local Testing done, working fine.

Checklist:

  • My changes generate no new warnings

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner July 20, 2021 11:16
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #1012 (92aa26f) into main (13f3a9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16862    16862           
  Branches     2190     2190           
=======================================
  Hits        14343    14343           
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...components/src/tabs/content/tab-group.component.ts 58.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f3a9a...92aa26f. Read the comment docs.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 9de0d0e into main Jul 20, 2021
@itssharmasandeep itssharmasandeep deleted the tab-design-fix branch July 20, 2021 11:24
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   15m 45s ⏱️ - 1m 45s
944 tests ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
951 runs  ±0  951 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9de0d0e. ± Comparison against base commit 13f3a9a.

@@ -17,10 +17,14 @@
color: $gray-9;
}

::ng-deep .ht-link:hover {
color: $gray-9;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

::ng-deep Shouldn't be required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants