feat: add esnext.string to ts libs #1013
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 820 820
Lines 16863 16863
Branches 2190 2190
=======================================
Hits 14344 14344
Misses 2488 2488
Partials 31 31 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
tsconfig.base.json
Outdated
| @@ -16,7 +16,7 @@ | |||
| "noUnusedLocals": true, | |||
| "noUnusedParameters": true, | |||
| "downlevelIteration": true, | |||
| "lib": ["es2015", "es2016", "es2017", "esnext.array", "esnext.asynciterable", "dom"], | |||
| "lib": ["es2015", "es2016", "es2017", "esnext.string","esnext.array", "esnext.asynciterable", "dom"], | |||
There was a problem hiding this comment.
did you verify that we polyfill these?
There was a problem hiding this comment.
Not everything, but I tested replaceAll. What else should I look for?
There was a problem hiding this comment.
we basically need to make sure that it works in any browser we support (not just local) - so either it's been implemented in all that we support, or safer - that core-js polyfills replaceall (I think that's all that comes in here, right?)
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Description
Added esnext.string to tsconfig libs.