Skip to content

feat: Adding unlimited value #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2021
Merged

feat: Adding unlimited value #1014

merged 2 commits into from
Jul 20, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jul 20, 2021

Description

Adding Unlimited (infinite) value to Bar Gauge.

Testing

Visual testing:

image

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner July 20, 2021 20:11
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #1014 (e78e9eb) into main (9de0d0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16862    16863    +1     
  Branches     2190     2190           
=======================================
+ Hits        14343    14344    +1     
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...shared/components/bar-gauge/bar-gauge.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de0d0e...e78e9eb. Read the comment docs.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit ba2ed52 into main Jul 20, 2021
@palbizu palbizu deleted the AddingUnlimitedBarGaugeOption branch July 20, 2021 20:26
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   17m 20s ⏱️ + 1m 35s
945 tests +1  945 ✔️ +1  0 💤 ±0  0 ❌ ±0 
952 runs  +1  952 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit ba2ed52. ± Comparison against base commit 9de0d0e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants