Skip to content

feat: Adding bar gauge htDisplayNumber pipe #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jul 21, 2021

Description

Adding HTDisplayNumber pipe to Bar Gauge

Testing

Visual Testing:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner July 21, 2021 19:00
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1016 (29aff5d) into main (c23f64d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1016   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16863    16863           
  Branches     2190     2190           
=======================================
  Hits        14344    14344           
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...shared/components/bar-gauge/bar-gauge.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23f64d...29aff5d. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit c75f40b into main Jul 21, 2021
@palbizu palbizu deleted the BarGaugeAddingPipe branch July 21, 2021 19:20
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   17m 10s ⏱️ +52s
945 tests ±0  945 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
952 runs  ±0  952 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c75f40b. ± Comparison against base commit c23f64d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants