Skip to content

Revert "feat: add option to open link in new tab" #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Reverts #1019

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner July 26, 2021 11:35
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1023 (a3db425) into main (260b9f9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   85.06%   85.06%   -0.01%     
==========================================
  Files         820      820              
  Lines       16864    16863       -1     
  Branches     2190     2190              
==========================================
- Hits        14345    14344       -1     
  Misses       2488     2488              
  Partials       31       31              
Impacted Files Coverage Δ
projects/components/src/link/link.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260b9f9...a3db425. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit e68fd39 into main Jul 26, 2021
@aaron-steinfeld aaron-steinfeld deleted the revert-1019-link-open-in-new-tab branch July 26, 2021 11:57
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   19m 57s ⏱️ + 2m 29s
945 tests ±0  945 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
952 runs  ±0  952 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e68fd39. ± Comparison against base commit 260b9f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants