Skip to content

refactor: adding nav changes #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2021
Merged

refactor: adding nav changes #1031

merged 3 commits into from
Jul 27, 2021

Conversation

anandtiwary
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1031 (fd5c6c5) into main (c90b652) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1031   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16863    16864    +1     
  Branches     2190     2190           
=======================================
+ Hits        14344    14345    +1     
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...ents/src/navigation/nav-item/nav-item.component.ts 100.00% <ø> (ø)
...onents/src/navigation/navigation-list.component.ts 84.00% <100.00%> (ø)
...omponents/src/navigation/navigation-list.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90b652...fd5c6c5. Read the comment docs.

@github-actions

This comment has been minimized.


.nav-item {
@include font-left-nav-label;
//@include box-shadow-2dp();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@jake-bassett jake-bassett marked this pull request as ready for review July 27, 2021 21:41
@jake-bassett jake-bassett requested a review from a team as a code owner July 27, 2021 21:41
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett self-requested a review July 27, 2021 22:02
@jake-bassett jake-bassett merged commit 5819213 into main Jul 27, 2021
@jake-bassett jake-bassett deleted the nav-changes branch July 27, 2021 23:09
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   16m 46s ⏱️ +39s
945 tests ±0  945 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
952 runs  ±0  952 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5819213. ± Comparison against base commit c90b652.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants