Skip to content

feat: creating a more condensed left to right topology layout #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 28, 2021

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1036 (e50555f) into main (978312f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   85.09%   85.10%           
=======================================
  Files         821      822    +1     
  Lines       16898    16913   +15     
  Branches     2196     2199    +3     
=======================================
+ Hits        14379    14393   +14     
- Misses       2488     2489    +1     
  Partials       31       31           
Impacted Files Coverage Δ
...y/src/shared/components/topology/d3/d3-topology.ts 91.95% <100.00%> (ø)
...mponents/topology/d3/layouts/custom-tree-layout.ts 100.00% <100.00%> (ø)
...ared/components/topology/d3/layouts/tree-layout.ts 95.77% <100.00%> (-1.41%) ⬇️
...y/renderers/edge/topology-edge-renderer.service.ts 79.62% <100.00%> (ø)
.../edge/curved/entity-edge-curve-renderer.service.ts 100.00% <100.00%> (ø)
...ology/node/box/entity-node-box-renderer.service.ts 80.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978312f...e50555f. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary marked this pull request as ready for review July 28, 2021 18:44
@anandtiwary anandtiwary requested a review from a team as a code owner July 28, 2021 18:44
@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit e2d498f into main Jul 28, 2021
@anandtiwary anandtiwary deleted the topology-perf-improvements branch July 28, 2021 18:54
@github-actions
Copy link

Unit Test Results

    4 files  ±0  263 suites  ±0   17m 5s ⏱️ +14s
947 tests ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e2d498f. ± Comparison against base commit 978312f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants