Skip to content

fix: fixing the child length #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix: fixing the child length #1038

merged 3 commits into from
Jul 30, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 29, 2021

Description

Please include a summary of the change, motivation and context.
fix: fixing the child length

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner July 29, 2021 23:28
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1038 (741706c) into main (7c2ba4b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1038   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files         822      822           
  Lines       16917    16917           
  Branches     2043     2043           
=======================================
  Hits        14397    14397           
  Misses       2489     2489           
  Partials       31       31           
Impacted Files Coverage Δ
...mponents/topology/d3/layouts/custom-tree-layout.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2ba4b...741706c. Read the comment docs.

jake-bassett
jake-bassett previously approved these changes Jul 29, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit f2452c6 into main Jul 30, 2021
@anandtiwary anandtiwary deleted the topology-overlap-fix branch July 30, 2021 05:41
@github-actions
Copy link

Unit Test Results

    4 files  ±0  263 suites  ±0   14m 52s ⏱️ -47s
947 tests ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f2452c6. ± Comparison against base commit 7c2ba4b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants