feat: allow custom tooltip titles #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1047 +/- ##
==========================================
- Coverage 85.09% 85.07% -0.03%
==========================================
Files 822 822
Lines 16919 16923 +4
Branches 2044 2045 +1
==========================================
Hits 14398 14398
- Misses 2490 2494 +4
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
anandtiwary
previously approved these changes
Aug 2, 2021
This comment has been minimized.
This comment has been minimized.
* feat: adding tick days distance parameter in cartesian-axis * feat: Adding d3-time * feat: removing implicit dependencies * feat: removing implicit dependencies * feat: adding tick count * feat: fixing lintern * feat: fixing comment Co-authored-by: Patricio Albizu <[email protected]>
This comment has been minimized.
This comment has been minimized.
anandtiwary
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow custom tooltips, and fix a bug in explore result mapping (the timestamp which matches the interval's end time is not an actual bucket and shouldn't produce a result).
Testing
Manual. Unit tests to follow 😢