Skip to content

feat: adding light bulb icon #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021
Merged

feat: adding light bulb icon #1059

merged 1 commit into from
Aug 10, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Aug 10, 2021

Description

Adding Light Bulb Icon

Testing

Visual testing:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner August 10, 2021 22:11
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1059 (da4077b) into main (cae469c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         822      822           
  Lines       16923    16923           
  Branches     2045     2045           
=======================================
  Hits        14398    14398           
  Misses       2494     2494           
  Partials       31       31           
Impacted Files Coverage Δ
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae469c...da4077b. Read the comment docs.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 4d289dd into main Aug 10, 2021
@palbizu palbizu deleted the AddingLightBulbIcon branch August 10, 2021 23:25
@github-actions
Copy link

Unit Test Results

    4 files  263 suites   16m 2s ⏱️
947 tests 947 ✔️ 0 💤 0 ❌
954 runs  954 ✔️ 0 💤 0 ❌

Results for commit 4d289dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants