fix: support anything coercer supports for date parsing #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1078 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 822 822
Lines 16924 16928 +4
Branches 2045 2045
=======================================
+ Hits 14399 14404 +5
+ Misses 2494 2493 -1
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Aug 19, 2021
| return value !== null ? new DateFormatter(options).format(value) : '-'; | ||
| private readonly dateCoercer: DateCoercer = new DateCoercer(); | ||
| public transform(value?: string | Date | number | null, options: DateFormatOptions = {}): string { | ||
| return isNil(value) ? '-' : new DateFormatter(options).format(this.dateCoercer.coerce(value)); |
There was a problem hiding this comment.
what if this.dateCoercer.coerce(value) returns undefined? Should we do this before the calling isNil so that we can assign '-'?
There was a problem hiding this comment.
Should the DateFormatter just depend on dateCoercer?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anandtiwary
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dates coming through as strings, even though we have the tools to parse them, are not supported today in the table parser or the date display pipe. This adds that support.
Testing
Manual, added UTs