Skip to content

chore: merging distributed-tracing into observability #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2021

Conversation

itssharmasandeep
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1090 (64924b6) into main (c5cedd3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   85.08%   85.12%   +0.03%     
==========================================
  Files         822      821       -1     
  Lines       16928    16965      +37     
  Branches     2044     2044              
==========================================
+ Hits        14404    14441      +37     
  Misses       2493     2493              
  Partials       31       31              
Impacted Files Coverage Δ
...ble/cells/data-parsers/table-cell-string-parser.ts 85.71% <ø> (ø)
...pi-trace-detail/api-trace-detail.page.component.ts 38.46% <ø> (ø)
.../api-trace-detail/logs/api-trace-logs.component.ts 60.00% <ø> (ø)
...ce-detail/sequence/api-trace-sequence.dashboard.ts 100.00% <ø> (ø)
...s/apis/api-detail/metrics/api-metrics.component.ts 100.00% <ø> (ø)
...s/apis/api-detail/metrics/api-metrics.dashboard.ts 100.00% <ø> (ø)
...apis/api-detail/overview/api-overview.component.ts 62.50% <ø> (ø)
...apis/api-detail/overview/api-overview.dashboard.ts 100.00% <ø> (ø)
...apis/api-detail/traces/api-trace-list.component.ts 62.50% <ø> (ø)
...apis/api-detail/traces/api-trace-list.dashboard.ts 100.00% <ø> (ø)
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cedd3...64924b6. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary
Copy link
Contributor

403 files. what did you do? :P

Copy link
Contributor

@anandtiwary anandtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Going to trust you on this one. :D

Please merge this after you have corresponding t-ui PR approved.

@itssharmasandeep
Copy link
Contributor Author

403 files. what did you do? :P

half to files were transferred and in half of the files, paths got updated

@itssharmasandeep itssharmasandeep merged commit 1f175de into main Aug 27, 2021
@itssharmasandeep itssharmasandeep deleted the merge-tracing-obs branch August 27, 2021 10:20
@github-actions
Copy link

Unit Test Results

    4 files  265 suites   18m 11s ⏱️
951 tests 951 ✔️ 0 💤 0 ❌
958 runs  958 ✔️ 0 💤 0 ❌

Results for commit 1f175de.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants