feat: Adding bar gauge new style #1091
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 821 821
Lines 16965 16965
Branches 2044 2044
=======================================
Hits 14441 14441
Misses 2493 2493
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
lgtm, but would appreciate @arjunlalb or @anandtiwary taking a look as well.
Unit Test Results 4 files 265 suites 17m 26s ⏱️ Results for commit ada938a. |
| @@ -162,5 +162,6 @@ interface BarSegment extends Segment { | |||
|
|
|||
| export const enum BarGaugeStyle { | |||
| Regular = 'regular', | |||
| Compact = 'compact' | |||
| Compact = 'compact', | |||
| SingleBar = 'single-bar' | |||
There was a problem hiding this comment.
May be naming could have been different. All of these are single bars only rights?
There was a problem hiding this comment.
Yes but the rest of the gauges have bars, references, title, etc... So in this case I have only a single bar.
Description
Testing
Visual Testing
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.