Skip to content

feat: adding donut's alignment #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 2, 2021
Merged

feat: adding donut's alignment #1104

merged 5 commits into from
Sep 2, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Sep 1, 2021

Description

Adding Donut's alignment property

Testing

Visual Testing

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner September 1, 2021 23:09
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1104 (2ee93e9) into main (1e4e07d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files         822      822           
  Lines       17007    17009    +2     
  Branches     2158     2158           
=======================================
+ Hits        14474    14476    +2     
  Misses       2502     2502           
  Partials       31       31           
Impacted Files Coverage Δ
...ity/src/shared/components/donut/donut.component.ts 100.00% <100.00%> (ø)
...bility/src/shared/components/donut/donut.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4e07d...2ee93e9. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 73431f7 into main Sep 2, 2021
@palbizu palbizu deleted the DonutAlignment branch September 2, 2021 17:47
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Unit Test Results

    4 files  ±0  265 suites  ±0   15m 55s ⏱️ -58s
957 tests ±0  957 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
964 runs  ±0  964 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 73431f7. ± Comparison against base commit 1e4e07d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants