Skip to content

feat: template functionality for radio button label #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

itssharmasandeep
Copy link
Contributor

Description

By this, we will be able to pass custom template as well for label.

Testing

Local testing done!!

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner September 8, 2021 06:15
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1113 (8bb4a84) into main (0c06bb1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files         822      822           
  Lines       17009    17011    +2     
  Branches     2158     2158           
=======================================
+ Hits        14476    14478    +2     
  Misses       2502     2502           
  Partials       31       31           
Impacted Files Coverage Δ
...ects/components/src/radio/radio-group.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c06bb1...8bb4a84. Read the comment docs.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 11705d0 into main Sep 8, 2021
@itssharmasandeep itssharmasandeep deleted the radio-template-label branch September 8, 2021 06:59
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Unit Test Results

    4 files  ±0  265 suites  ±0   17m 20s ⏱️ - 1m 16s
957 tests ±0  957 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
964 runs  ±0  964 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 11705d0. ± Comparison against base commit 0c06bb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants