Skip to content

refactor: adding type and reading from window freshpaint #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Oct 1, 2021

Description

Please include a summary of the change, motivation and context.
refactor: adding type and reading from window freshpaint

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner October 1, 2021 06:37
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1166 (8e6b77e) into main (b65d383) will decrease coverage by 0.01%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   85.04%   85.02%   -0.02%     
==========================================
  Files         831      831              
  Lines       17210    17215       +5     
  Branches     2235     2238       +3     
==========================================
+ Hits        14636    14637       +1     
- Misses       2542     2546       +4     
  Partials       32       32              
Impacted Files Coverage Δ
...emetry/providers/freshpaint/freshpaint-provider.ts 15.78% <0.00%> (-4.22%) ⬇️
...ommon/src/telemetry/user-telemetry-impl.service.ts 90.69% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65d383...8e6b77e. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit deaf43b into main Oct 1, 2021
@anandtiwary anandtiwary deleted the telemetry-followup-1 branch October 1, 2021 07:19
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Unit Test Results

    4 files  ±0  270 suites  ±0   17m 13s ⏱️ -6s
968 tests ±0  968 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
975 runs  ±0  975 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit deaf43b. ± Comparison against base commit b65d383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants